Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

ensure metaspace changes correctly notify listeners #8611

Merged
merged 3 commits into from
May 18, 2022
Merged

ensure metaspace changes correctly notify listeners #8611

merged 3 commits into from
May 18, 2022

Conversation

justjanne
Copy link
Contributor

@justjanne justjanne commented May 16, 2022 •
edited by github-actions bot
Loading

Type: Defect
Closes: element-hq/element-web#21006

The previous flow of events:

  1. SpaceStore is created. enabledMetaSpaces and spacePanelSpaces are empty
  2. Sometimes SpacePanel is initialized at this point already and loads the empty enabledMetaSpaces and spacePanelSpaces from the SpaceStore.
  3. SpaceStore loads the actual lists and updates enabledMetaSpaces and spacePanelSpaces. Only if spacePanelSpaces has changed, SpaceStore will notify the SpacePanel
  4. SpacePanel updates the lists
  5. Sometimes SpacePanel is initialized only at this point and loads the current enabledMetaSpaces and spacePanelSpaces from the SpaceStore.
  6. If at any later point enabledMetaSpaces or spacePanelSpaces change, SpaceStore notifies the SpacePanel, which updates itself.

Note the race condition (SpacePanel initializing either at point 2 or 5) and the actual logic bug (bold, in point 3).

This PR fixes that logic bug, causing SpaceStore to notify its listeners, including the SpacePanel, during onReady even if only metaSpaces have been loaded.

Here's what your changelog entry will look like:

🐛 Bug Fixes

@justjanne justjanne added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 16, 2022
@justjanne justjanne marked this pull request as ready for review May 16, 2022 14:28
@justjanne justjanne requested a review from a team as a code owner May 16, 2022 14:28
robintown
robintown reviewed May 16, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a test perhaps be written for this?

@justjanne justjanne force-pushed the justjanne/fix/21006-metaspaces-missing-without-spaces branch from 8f9a4cf to a3aab29 Compare May 18, 2022 10:28
@justjanne justjanne force-pushed the justjanne/fix/21006-metaspaces-missing-without-spaces branch from a3aab29 to c576e8a Compare May 18, 2022 10:35
@justjanne justjanne requested a review from robintown May 18, 2022 11:31
@justjanne justjanne changed the title fix: ensure metaspace changes correctly notify listeners ensure metaspace changes correctly notify listeners May 18, 2022
@justjanne justjanne merged commit 2d38655 into develop May 18, 2022
@justjanne justjanne deleted the justjanne/fix/21006-metaspaces-missing-without-spaces branch May 18, 2022 13:15
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Jun 7, 2022
@su-ex
Merge tag 'v1.10.14' into sc
bb2a41e 
* Builds Windows 32-bit builds once more! ([\element-hq#369](element-hq#369)). Fixes element-hq/element-web#13175.
* Option to disable hardware acceleration ([\element-hq#365](element-hq#365)). Fixes element-hq/element-web#13648. Contributed by @novocaine.
* Make Lao translation available ([\#22358](element-hq/element-web#22358)). Fixes element-hq/element-web#22327.
* Option to disable hardware acceleration on Element Desktop ([\#22295](element-hq/element-web#22295)). Contributed by @novocaine.
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq/element-web#22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\#8471](matrix-org/matrix-react-sdk#8471)).
* Add the option to disable hardware acceleration ([\#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq/element-web#22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq/element-web#19883.
* Add public room directory hook ([\#8626](matrix-org/matrix-react-sdk#8626)).
* Revert back to using libsqlcipher0 for Debian & Ubuntu packages of Desktop ([\element-hq#367](element-hq#367)). Fixes element-hq/element-web#22325.
* Stop Jitsi if we time out while connecting to a video room ([\#22301](element-hq/element-web#22301)). Fixes element-hq/element-web#22283.
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq/element-web#22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq/element-web#22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq/element-web#22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq/element-web#17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq/element-web#22337.
* Align EventTile_line with display name on message bubble ([\#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq/element-web#22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\#8687](matrix-org/matrix-react-sdk#8687)).
* Make the empty thread panel fill BaseCard ([\#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq/element-web#22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\#8686](matrix-org/matrix-react-sdk#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq/element-web#21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq/element-web#22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq/element-web#22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\#8660](matrix-org/matrix-react-sdk#8660)).
* Fix file button and audio player overflowing from message bubble ([\#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq/element-web#22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq/element-web#10788.
* Fix media upload http 413 handling ([\#8674](matrix-org/matrix-react-sdk#8674)).
* Fix emoji picker for editing thread responses ([\#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq/element-web#22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq/element-web#22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq/element-web#22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq/element-web#22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq/element-web#22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq/element-web#22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq/element-web#22300. Contributed by @luixxiul.
* Automatically log in after registration ([\#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq/element-web#19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\#8656](matrix-org/matrix-react-sdk#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq/element-web#22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq/element-web#22279.
* Show notifications even when Element is focused ([\#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq/element-web#21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq/element-web#22244.
* Adjust EditMessageComposer style declarations ([\#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq/element-web#22231. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/element-web that referenced this pull request Jun 7, 2022
@su-ex
Merge tag 'v1.10.14' into sc
4b5042b 
* Make Lao translation available ([\element-hq#22358](element-hq#22358)). Fixes element-hq#22327.
* Option to disable hardware acceleration on Element Desktop ([\element-hq#22295](element-hq#22295)). Contributed by @novocaine.
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\element-hq#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\element-hq#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\element-hq#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq#22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\element-hq#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\element-hq#8471](matrix-org/matrix-react-sdk#8471)).
* Add the option to disable hardware acceleration ([\element-hq#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\element-hq#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq#22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\element-hq#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq#19883.
* Add public room directory hook ([\element-hq#8626](matrix-org/matrix-react-sdk#8626)).
* Stop Jitsi if we time out while connecting to a video room ([\element-hq#22301](element-hq#22301)). Fixes element-hq#22283.
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\element-hq#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq#22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\element-hq#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq#22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\element-hq#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\element-hq#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq#22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\element-hq#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\element-hq#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq#17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\element-hq#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq#22337.
* Align EventTile_line with display name on message bubble ([\element-hq#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq#22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\element-hq#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\element-hq#8687](matrix-org/matrix-react-sdk#8687)).
* Make the empty thread panel fill BaseCard ([\element-hq#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq#22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\element-hq#8686](matrix-org/matrix-react-sdk#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\element-hq#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq#21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\element-hq#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq#22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\element-hq#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq#22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\element-hq#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\element-hq#8660](matrix-org/matrix-react-sdk#8660)).
* Fix file button and audio player overflowing from message bubble ([\element-hq#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq#22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\element-hq#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq#10788.
* Fix media upload http 413 handling ([\element-hq#8674](matrix-org/matrix-react-sdk#8674)).
* Fix emoji picker for editing thread responses ([\element-hq#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\element-hq#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq#22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\element-hq#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq#22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\element-hq#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq#22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\element-hq#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq#22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\element-hq#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq#22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\element-hq#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq#22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\element-hq#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq#22300. Contributed by @luixxiul.
* Automatically log in after registration ([\element-hq#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq#19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\element-hq#8656](matrix-org/matrix-react-sdk#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\element-hq#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq#22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\element-hq#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\element-hq#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq#22279.
* Show notifications even when Element is focused ([\element-hq#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\element-hq#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\element-hq#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq#21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\element-hq#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq#22244.
* Adjust EditMessageComposer style declarations ([\element-hq#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq#22231. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Jun 7, 2022
@su-ex
Merge tag 'v3.46.0' into sc
56703ed 
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\matrix-org#7790](matrix-org#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\matrix-org#8695](matrix-org#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\matrix-org#8701](matrix-org#8701)). Fixes element-hq/element-web#22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\matrix-org#8550](matrix-org#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\matrix-org#8471](matrix-org#8471)).
* Add the option to disable hardware acceleration ([\matrix-org#8655](matrix-org#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\matrix-org#8662](matrix-org#8662)). Fixes element-hq/element-web#22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\matrix-org#6775](matrix-org#6775)). Fixes element-hq/element-web#19883.
* Add public room directory hook ([\matrix-org#8626](matrix-org#8626)).
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\matrix-org#8708](matrix-org#8708)). Fixes element-hq/element-web#22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\matrix-org#8700](matrix-org#8700)). Fixes element-hq/element-web#22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\matrix-org#8697](matrix-org#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\matrix-org#8704](matrix-org#8704)). Fixes element-hq/element-web#22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\matrix-org#8682](matrix-org#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\matrix-org#8670](matrix-org#8670)). Fixes element-hq/element-web#17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\matrix-org#8698](matrix-org#8698)). Fixes element-hq/element-web#22337.
* Align EventTile_line with display name on message bubble ([\matrix-org#8692](matrix-org#8692)). Fixes element-hq/element-web#22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\matrix-org#8694](matrix-org#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\matrix-org#8687](matrix-org#8687)).
* Make the empty thread panel fill BaseCard ([\matrix-org#8690](matrix-org#8690)). Fixes element-hq/element-web#22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\matrix-org#8686](matrix-org#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\matrix-org#8688](matrix-org#8688)). Fixes element-hq/element-web#21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\matrix-org#8669](matrix-org#8669)). Fixes element-hq/element-web#22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\matrix-org#8680](matrix-org#8680)). Fixes element-hq/element-web#22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\matrix-org#8679](matrix-org#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\matrix-org#8660](matrix-org#8660)).
* Fix file button and audio player overflowing from message bubble ([\matrix-org#8666](matrix-org#8666)). Fixes element-hq/element-web#22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\matrix-org#8673](matrix-org#8673)). Fixes element-hq/element-web#10788.
* Fix media upload http 413 handling ([\matrix-org#8674](matrix-org#8674)).
* Fix emoji picker for editing thread responses ([\matrix-org#8671](matrix-org#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\matrix-org#8621](matrix-org#8621)). Fixes element-hq/element-web#22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\matrix-org#8639](matrix-org#8639)). Fixes element-hq/element-web#22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\matrix-org#8667](matrix-org#8667)). Fixes element-hq/element-web#22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\matrix-org#8456](matrix-org#8456)). Fixes element-hq/element-web#22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\matrix-org#8665](matrix-org#8665)). Fixes element-hq/element-web#22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\matrix-org#8663](matrix-org#8663)). Fixes element-hq/element-web#22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\matrix-org#8658](matrix-org#8658)). Fixes element-hq/element-web#22300. Contributed by @luixxiul.
* Automatically log in after registration ([\matrix-org#8654](matrix-org#8654)). Fixes element-hq/element-web#19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\matrix-org#8656](matrix-org#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\matrix-org#8636](matrix-org#8636)). Fixes element-hq/element-web#22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\matrix-org#8650](matrix-org#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\matrix-org#8648](matrix-org#8648)). Fixes element-hq/element-web#22279.
* Show notifications even when Element is focused ([\matrix-org#8590](matrix-org#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\matrix-org#8632](matrix-org#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\matrix-org#8611](matrix-org#8611)). Fixes element-hq/element-web#21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\matrix-org#8641](matrix-org#8641)). Fixes element-hq/element-web#22244.
* Adjust EditMessageComposer style declarations ([\matrix-org#8631](matrix-org#8631)). Fixes element-hq/element-web#22231. Contributed by @luixxiul.
estellecomment added a commit to tchapgouv/tchap-web-v4 that referenced this pull request Jun 13, 2022
@estellecomment
Merge tag 'v1.10.14' into rebase/element-web-1.10.14 (with conflicts)
1243cf7 
* Make Lao translation available ([\#22358](element-hq/element-web#22358)). Fixes #22327.
* Option to disable hardware acceleration on Element Desktop ([\#22295](element-hq/element-web#22295)). Contributed by @novocaine.
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\#8701](matrix-org/matrix-react-sdk#8701)). Fixes #22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\#8471](matrix-org/matrix-react-sdk#8471)).
* Add the option to disable hardware acceleration ([\#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\#8662](matrix-org/matrix-react-sdk#8662)). Fixes #22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\#6775](matrix-org/matrix-react-sdk#6775)). Fixes #19883.
* Add public room directory hook ([\#8626](matrix-org/matrix-react-sdk#8626)).
* Stop Jitsi if we time out while connecting to a video room ([\#22301](element-hq/element-web#22301)). Fixes #22283.
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\#8708](matrix-org/matrix-react-sdk#8708)). Fixes #22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\#8700](matrix-org/matrix-react-sdk#8700)). Fixes #22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\#8704](matrix-org/matrix-react-sdk#8704)). Fixes #22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\#8670](matrix-org/matrix-react-sdk#8670)). Fixes #17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\#8698](matrix-org/matrix-react-sdk#8698)). Fixes #22337.
* Align EventTile_line with display name on message bubble ([\#8692](matrix-org/matrix-react-sdk#8692)). Fixes #22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\#8687](matrix-org/matrix-react-sdk#8687)).
* Make the empty thread panel fill BaseCard ([\#8690](matrix-org/matrix-react-sdk#8690)). Fixes #22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\#8686](matrix-org/matrix-react-sdk#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\#8688](matrix-org/matrix-react-sdk#8688)). Fixes #21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\#8669](matrix-org/matrix-react-sdk#8669)). Fixes #22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\#8680](matrix-org/matrix-react-sdk#8680)). Fixes #22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\#8660](matrix-org/matrix-react-sdk#8660)).
* Fix file button and audio player overflowing from message bubble ([\#8666](matrix-org/matrix-react-sdk#8666)). Fixes #22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\#8673](matrix-org/matrix-react-sdk#8673)). Fixes #10788.
* Fix media upload http 413 handling ([\#8674](matrix-org/matrix-react-sdk#8674)).
* Fix emoji picker for editing thread responses ([\#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\#8621](matrix-org/matrix-react-sdk#8621)). Fixes #22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\#8639](matrix-org/matrix-react-sdk#8639)). Fixes #22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\#8667](matrix-org/matrix-react-sdk#8667)). Fixes #22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\#8456](matrix-org/matrix-react-sdk#8456)). Fixes #22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\#8665](matrix-org/matrix-react-sdk#8665)). Fixes #22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\#8663](matrix-org/matrix-react-sdk#8663)). Fixes #22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\#8658](matrix-org/matrix-react-sdk#8658)). Fixes #22300. Contributed by @luixxiul.
* Automatically log in after registration ([\#8654](matrix-org/matrix-react-sdk#8654)). Fixes #19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\#8656](matrix-org/matrix-react-sdk#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\#8636](matrix-org/matrix-react-sdk#8636)). Fixes #22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\#8648](matrix-org/matrix-react-sdk#8648)). Fixes #22279.
* Show notifications even when Element is focused ([\#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\#8611](matrix-org/matrix-react-sdk#8611)). Fixes #21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\#8641](matrix-org/matrix-react-sdk#8641)). Fixes #22244.
* Adjust EditMessageComposer style declarations ([\#8631](matrix-org/matrix-react-sdk#8631)). Fixes #22231. Contributed by @luixxiul.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@robintown robintown Awaiting requested review from robintown

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metaspaces are not shown if no real spaces in panel
3 participants
@justjanne @t3chguy @robintown